Interface IRouteMeta define API for RoutingPanel.#114
Interface IRouteMeta define API for RoutingPanel.#114h4kuna wants to merge 1 commit intonette:masterfrom h4kuna:routingpanel-api
Conversation
src/Application/IRouteMeta.php
Outdated
There was a problem hiding this comment.
Nette doesn't use visibility in interfaces.
|
I don't like the name, it sounds like an abbreviation. :/ |
|
@Majkl578 What do you suggest? I named in issue as IRouteBar. What do you think about IRouteInfo, IRouteMask, IRouteMaskBar, IRoutingPanelRoute? |
|
Generally good idea but the issue is much more complex. |
20a93ca to
08cbdeb
Compare
|
@JanTvrdik Let's describe it. |
|
You need to consider custom routers (which can do pretty much anything) as well. Some custom routers may be just wrappers of another routers, some do complex logic. The entire interface of routing bar may need to be redesigned to be able to clearly display advanced router configurations. For start it needs to support tree of routers, not a list. |
|
@JanTvrdik You are true, but I think this is good step forward. |
2c1ae3b to
b42b3fe
Compare
8e388e3 to
aca6b40
Compare
c73b255 to
9e7cd60
Compare
ea11e9d to
8ff194f
Compare
7447ad4 to
3165d3a
Compare
3fb5d4a to
d2e3dc1
Compare
07d4ebb to
337c67c
Compare
9fecad4 to
e12e3ab
Compare
Issue #113